Add ORIBI script to index html + Merge 'about' pages of images and videos - Githubissues

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il

GNU Affero General Public License v3.0

10 stars 13 forks source link

Add ORIBI script to index html + Merge 'about' pages of images and videos #370

Closed Libisch closed 7 years ago

Libisch commented 7 years ago

1. Add ORIBI script to index html

Oribi is an analytics tool we wish to test, See #355
Code from here was added only to google tag manager in index.html. @OriHoch @TheGrandVizier Requires detailed review to test effect on website, if any.

2. Merge 'about' pages of images and videos

see #371
Changed links on footer.html: instead of 'Images' and 'Videos' there should be one link: 'Visual Documentation'.
The text was originally identical, so the only change in allresults.html is the value of ng-switch ('visula_documentation' instead of 'images' and 'videos'), and deletion of the unused (identical) text.

Libisch commented 7 years ago

Oribi's code should not yet be merged, and documentation should be in a new branch. Closing this to create new pull requests.