Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Wizard should not add spaces when suggesting peoples names. #379

Open nuritgazit opened 7 years ago

nuritgazit commented 7 years ago

causing no results: image

Reproduce:

Expected:

Actual results:

Inna-r commented 7 years ago

Extra spaces aren't the reason we don't get 'persons' results. The same search term works well for 'persons' tab, but not for 'All results'. It should be '&with_persons=1' parameter added to get person results under all results tab. it's another issue

OriHoch commented 7 years ago

thanks @Inna-r I understand it's a problem on backend? please link to backend issue if that's the case

TheGrandVizier commented 7 years ago

This becomes irrelevant if we remove General Suggestions.

Inna-r commented 7 years ago

@TheGrandVizier, the problematic results (with extra spaces) are persons only, and we want to suggest them later in wizard. so it is relevant

OriHoch commented 7 years ago

@Inna-r @TheGrandVizier what's the status of this issue? I currently don't see any bug or problem, expect minor issue of having some extra spaces, but if that's the only problem, then it seems an extremely low priority bug, and not worth spending time on IMO

TheGrandVizier commented 7 years ago

@OriHoch You are correct