The "No Results" report should include Person / tree filters

[TheGrandVizier]

Reproduce:

1. Search for "Nikolai" in general search
2. Go People tab
3. Add filter: Place: Jaffa
4. Click "Filter"

Expected result: Receive message that says there is no results for Nikolai that was born in / married in / died in jaffa.

Actual result: Receive a messasge that says there are no results for Nikolai

Note: The "No results" message should know how to "read" the filters used by the users.

[Netush]

Look st the sketch English: https://projects.invisionapp.com/d/main#/console/904587/234817805/preview Hebrew: https://projects.invisionapp.com/d/main#/console/904587/234817806/preview

[OriHoch]

@TheGrandVizier @Netush please decide on the expected result currently what's written in description doesn't match what's in the sketch

[OriHoch]

It seems to be it will be easiest to implement the pages to look like the sketch @Netush sent - as they don't contain reference to the actual search terms / filters

[nuritgazit]

I actually think we should do both: provide the exact description of why we couldn't find results ("We found no results for Nikolai + Jaffa") AND Provide the general text that explains how to improve search results.

[Netush]

So this is the recent sketch: (Click to the left to see the English sketch) https://projects.invisionapp.com/d/main#/console/904587/123938613/preview

[OriHoch]

@Netush @TheGrandVizier I understand issue was re-opened? please write a few words about the reason and what changes should be made

[TheGrandVizier]

Accidental close, thus reopened. Nothing happened.

[OriHoch]

thanks @TheGrandVizier - so what's the status of this issue? I see it was completed and ready for QA - but before @Netush comments if that's the case - I suggest to implement the new designs in a new issue

[TheGrandVizier]

Already done.

On Jun 5, 2017 5:34 PM, "Ori Hoch" notifications@github.com wrote:

thanks @TheGrandVizier https://github.com/thegrandvizier - so what's the status of this issue? I see it was completed and ready for QA - but before @Netush https://github.com/netush comments if that's the case - I suggest to implement the new designs in a new issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Beit-Hatfutsot/dbs-front/issues/394#issuecomment-306203212, or mute the thread https://github.com/notifications/unsubscribe-auth/AOfPtc8RywZ9TxtRrQ7PP9TfNh2Jprs5ks5sBBHVgaJpZM4NhkSx .

[OriHoch]

cool, thanks @TheGrandVizier could you link here to the new issue?

I'll delete @Netush comments with the new designs because they are confusing (to me..)

[OriHoch]

found the new issue -

410

@Netush - please review the new issue and ensure the spec and design is clear and correct..