Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Use image_url from API response #405

Open Inna-r opened 7 years ago

Inna-r commented 7 years ago

issue #351

notes

Libisch commented 7 years ago

@OriHoch - I'll try to review the current situation, so we can decide on how to proceed with this issue. @TheGrandVizier please correct me if I'm wrong:

Currently, there are three types of pictures (Item['Pictures']) in photoUnits: 1. picture does not have a pictureId, therefore does not have a PictureUrl: Item page, Pictures[1]:

screen shot 2017-06-11 at 14 56 27

2. picture has a PictureId, has a PictureUrl, but it's not valid: Item page, Pictures[0]:

screen shot 2017-06-11 at 14 53 10

3. picture has a valid PictureId and there for has a valid PictureUrl: Item page, Picture[0]:

screen shot 2017-06-11 at 15 02 28

Reproduce: