search

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Add title and description to DBs site in English #408

Closed nuritgazit closed 6 years ago

nuritgazit commented 7 years ago

We have today a title and description in Hebrew, but not in English. We should also have them in English. Here they are:

Title: Databases: Images, Name Meanings, Family Trees, Communities | BH

Description: Search archives of images & videos, last names, family trees, Jewish communities, luminaries & more via the free, open databases of The Museum of The Jewish People

Libisch commented 7 years ago

Done. See PR #409

OriHoch commented 7 years ago

@nuritgazit @Libisch I assume the goal of this is SEO? if yes, then it was not fixed..

you can see for example in facebook debugger - https://developers.facebook.com/tools/debug/sharing/?q=http%3A%2F%2Fdbs.bh.org.il%2F

looks like the problem is with how angular works - the properties are not available in the page source, only populated in JS

OriHoch commented 7 years ago

@TheGrandVizier FYI

nuritgazit commented 7 years ago

Yes, the goal is SEO. Is there a solution?

OriHoch commented 7 years ago

yes, there are solutions, need to prioritize and work on it

Netush commented 7 years ago

Sharon from SEO claims it is done and OK, but because of what Ori wrote, we are double checking. Now waiting for her final feedback.