"Exit Tree" should lead back to your latest search results

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il

GNU Affero General Public License v3.0

10 stars 13 forks source link

"Exit Tree" should lead back to your latest search results #419

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

Reproduce

View a tree
Click "Exit tree".

Expected Result:

Taken to the screen you viewed prior to entering the tree

Actual Result:

Taken to http://test.dbs.bh.org.il/search which displays an empty UI.

TheGrandVizier commented 7 years ago

Bonus points if it can go back to the actual part of the result screen the user was last at (correct amount of "Show more").

OriHoch commented 7 years ago

I had a look at the code, it's not trivial to fix because we don't have the mechanism to do that (from what I could see)

TheGrandVizier commented 7 years ago

Note #1: Currently the Exit Tree buttno does take a user back to the relevant results if the filters are used prior to entry to tree.

Note #2: A user can enter a tree from his MJS. This needs to be accounted for in any fix.

Netush commented 7 years ago

Just for notice- there are 3 ways to exit a tree 1 from the general search results > All Results 2 From the general search results > People (Family Trees) 3 From "My Story"

Libisch commented 7 years ago

PR #423 merged.