search

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Marriage date and place and place of death are not displayed in person details #434

Open TheGrandVizier opened 7 years ago

TheGrandVizier commented 7 years ago

Reproduce:

  1. View Nathaniel Goldman here: http://dbs.bh.org.il/person/1/0/I034
  2. Open details box
  3. Look for Place and / or date of marriage
  4. Look for his place of death

Expected result:

  1. Find place of marriage
  2. Find date of marriage
  3. Find place of death

Actual result:

  1. No place of marriage
  2. No date of marriage
  3. No place of death

Notes: @Netush

Netush commented 7 years ago

douglas7

TheGrandVizier commented 7 years ago

Here is the response you get from API:

NAME "RICHARD NATHANIEL /GOLDMAN/" tree_file_id "56e717b2-cba8-4c58-a747-91454ef48ef7" DEAT_PLAC_S "ZZ E467964 E467965 ZZ " id "I034" partners [1] FAMC "@F08@" EVEN_SOUR "@S1762@" OCCU_PLAC "INSURANCE BROKER. PRESIDENT O…NIV. OF CALIFORNIA, BERKELEY" SEX "M" EVEN_TYPE "RECD" parents [2] death_place "SAN FRANCISCO, CA, USA" siblings [1] Slug Object birth_year 1920 tree_version 0 marriage_years null tree_num 1 CHAN_DATE "29 MAY 1985" FAMS "@F06@" death_year 2010 tree_size 115 DEAT_PLAC_lc "san francisco, ca, usa" sex "M" RELI_PLAC "JEWISH" name_S [2] DEAT_DATE "29 NOV 2010" name [2] name_lc [2] BIRT_DATE "16 APR 1920" BIRT_PLAC_lc "san francisco, ca, usa" birth_place "SAN FRANCISCO, CA, USA" BIRT_PLAC_S "ZZ E467964 E467965 ZZ " deceased true

Note that there is no marriage place at all. Note that marriage years is null.

Bonus: Why are we repeating the birth place so much?

OriHoch commented 7 years ago

everything relating to persons data will change when we move to Clearmash

will have to see what we get from them