item without any content shouldn't be displayed - or show a different error message - Githubissues

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il

GNU Affero General Public License v3.0

10 stars 13 forks source link

item without any content shouldn't be displayed - or show a different error message #436

Closed OriHoch closed 7 years ago

OriHoch commented 7 years ago

reproduction

http://test.dbs.bh.org.il/he/%D7%95%D7%99%D7%90%D7%96%D7%9E%D7%94-%D7%9C%D7%99%D7%93-%D7%9E%D7%95%D7%A1%D7%A7%D7%91%D7%94/%D7%9E%D7%A7%D7%95%D7%9D
click on "click here to go to english version"

expected

english version

actual

click here to go to hebrew version
go back to beginning and repeat the loop

notes

not sure if it's frontend or backend bug
need to check if it's really missing content - in which case I guess we shouldn't sync it at all (pipelines shouldn't sync bad items)
or, check if there is another problem, maybe content is in a different field

OriHoch commented 7 years ago

it was a bug in pipelines sync - which synced items without content

fixed now, item now returns 404 as it should