Add Profile Screen - Githubissues

BekahHW / postpartum-wellness-app

An app to help moms monitor their well-being during the post-partum stage.

MIT License

42 stars 37 forks source link

Add Profile Screen #102

Closed dominicduffin1 closed 1 year ago

dominicduffin1 commented 1 year ago

Closes #93

Changes Proposed in this Pull Request:

Added a Profile screen with hard coded data for now.
Added a Profile button on home to enable navigation to this screen, this can be removed or moved somewhere else.

Questions for Review

Any design feedback would be welcome.
I have not included the colored shapes in the background of the proposed design, is there an asset I should use for the background?

@BekahHW

BekahHW commented 1 year ago

@dominicduffin1 This is looking great! Thanks for taking this on. Let's move the name Text elements down a little bit. The border-radius isn't show up on the name Text elements on my ios version. I think you'll need to wrap those in a <View> element to get the border-radius working. Let me know if you have any other questions.

I think we're fine to leave the other elements out now. I do really like how this is looking.

dominicduffin1 commented 1 year ago

@BekahHW Thank you, I'll work on your feedback! I forgot to say I can only test on Android, will add those <View> elements.

dominicduffin1 commented 1 year ago

@BekahHW I have added View elements and tweaked the styling, what do you think? Is the border-radius now showing on ios?

BekahHW commented 1 year ago

@dominicduffin1 are you getting any JSX errors when you try to run it?

dominicduffin1 commented 1 year ago

@BekahHW The only error I'm seeing is this one: EventEmitter.removeListener('keyboardDidHide', ...): Method has been deprecated. Please instead use 'remove()' on the subscription returned by 'EventEmitter.addListener'. It occurs on all the screens linked from the Home buttons and I think but am not certain that it was there when I ran the project before starting. Are you seeing the same error or a different one?

Screenshot_20221110-191326 Screenshot_20221110-191104