BekahT / VetApp

A Java desktop application to be used in a veterinarian's office for managing clients, pets, and appointments.
0 stars 0 forks source link

Add client #4

Closed BekahT closed 4 years ago

BekahT commented 4 years ago

Staff can add a new client with first name, last name, phone number, and email address.

BekahT commented 4 years ago
cp-umuc commented 4 years ago

Trying to put something invalid in the create client window causes a pop up window instead of a red error message to appear and when you close the pop up the entire create client window disappears so the user has to start over. Should be a red error message and user stays on the same page.

Screen Shot 2020-04-16 at 7 20 12 AM
cp-umuc commented 4 years ago

What are the invalid character list we are using? I feel like this should be okay...

Screen Shot 2020-04-16 at 7 23 58 AM
cp-umuc commented 4 years ago

There isn't validation on the phone number and formatting isn't present

Screen Shot 2020-04-16 at 7 28 42 AM
BekahT commented 4 years ago
cp-umuc commented 4 years ago

Clicking submit with missing fields doesn't result in same type of error message as invalid field values (in console instead)

nour-d commented 4 years ago

Trying to put something invalid in the create client window causes a pop up window instead of a red error message to appear and when you close the pop up the entire create client window disappears so the user has to start over. Should be a red error message and user stays on the same page.

Screen Shot 2020-04-16 at 7 20 12 AM

Just fixed both issues in features-new branch

BekahT commented 4 years ago

Already done

Added by me

cp-umuc commented 4 years ago

Phone number validation is still not right - I can submit an empty phone number and when an invalid number is entered (less than 10 numbers) an incorrect error message is displayed.

Screen Shot 2020-04-17 at 8 21 26 PM
BekahT commented 4 years ago

Resolved phone number validation in https://github.com/BekahT/VetApp/pull/44