search

BelaPlatform / bela-image-builder

Scripts to build a Bela image from scratch
MIT License
36 stars 16 forks source link

systemctl scripts should exit with an error regardless of how they have been started #73

Closed giuliomoro closed 4 years ago

giuliomoro commented 6 years ago

they are started with /bin/bash /path/to/script, therefore the -e in the #!/bin/bash -e shebang is ignored. We could add -e to all the invocations, or (safer?) add set -e in each script. See e.g.: https://github.com/BelaPlatform/bela-image-builder/commit/d3c527cf4188ff987d7e1e91b477f28b61ea4d2f

giuliomoro commented 6 years ago

and remember https://github.com/BelaPlatform/bela-image-builder/issues/72

giuliomoro commented 4 years ago

I think only bela_flash_emmc.sh deserves -e. So this was closed in 8a6815de3c77fa89756d5e0f7b5fb8bbbe8c3554