AnalogOut: warn for invalid analogPin only on change

BelaPlatform / supercollider

an environment and programming language for real time audio synthesis and algorithmic composition

GNU General Public License v3.0

14 stars 8 forks source link

AnalogOut: warn for invalid analogPin only on change #76

Closed elgiano closed 3 years ago

elgiano commented 3 years ago

Purpose and Motivation

Fixes #65

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] All tests are passing
[x] This PR is ready for review

Remaining Work

giuliomoro commented 3 years ago

New commit looks good, thanks. Would you be able to do something similar for the digital and analogIn ugens?

elgiano commented 3 years ago

Sure, in this PR or another?

giuliomoro commented 3 years ago

this one will be fine, thanks a lot!

elgiano commented 3 years ago

I see DigitalIn and DigitalOut are supposed to have pinIndices fixed at construction. It doesn't make sense then to have a check like we put in AnalogOut. I can do AnalogIn, but should I leave DigitalIn and Out be as they are?

giuliomoro commented 3 years ago

sounds good sure!

elgiano commented 3 years ago

done!

giuliomoro commented 3 years ago

thanks!