BelaScope: SC_BelaDriver implementation - Githubissues

BelaPlatform / supercollider

an environment and programming language for real time audio synthesis and algorithmic composition

GNU General Public License v3.0

14 stars 8 forks source link

BelaScope: SC_BelaDriver implementation #83

Closed elgiano closed 3 years ago

elgiano commented 3 years ago

Purpose and Motivation

Simpler implementation, with more responsibilities on the server, and more straightforward in general:

SC_BelaDriver's SC_World now has a BelaScope object, made of a Scope and a buffer where UGens can write data to be scoped (float[maxScopeChannels * blockSize])
If the server is started with belaMaxScopeChannels > 0, SC_BelaDriver inits a BelaScope, and logs from buffer to Scope at the end of every BelaAudioCallback
There is only one UGen, BelaScopeOut, which writes to BelaScope's buffer, and it's directly usable from clients

Types of changes

Documentation (non-code change which corrects or adds documentation for existing features)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

[ ] All tests are passing
[ ] If necessary, new tests were created to address changes in PR, and tests are passing
[ ] Updated documentation, if necessary
[ ] This PR is ready for review

Remaining Work

BelaScopeUGen: check valid
Further simplify sclang-side?
Review code organization: where would it be best to put SC_BelaScope.h functionalities?

giuliomoro commented 3 years ago

I have rebased the bela-merge-formatted-rebase branch to put all the three Scope-related commits on top (this can be sen in https://github.com/BelaPlatform/supercollider/commits/bela-scope-split ), then squashed them, so that the diff is now between no-scope and new-scope and not between old-scope and new-scope and it's easier to reason about it. That's in #84, which supersedes this #83.