BelaServerOptions subclass + examples and primitive fixes - Githubissues

BelaPlatform / supercollider

an environment and programming language for real time audio synthesis and algorithmic composition

GNU General Public License v3.0

14 stars 8 forks source link

BelaServerOptions subclass + examples and primitive fixes #86

Closed elgiano closed 3 years ago

elgiano commented 3 years ago

Purpose and Motivation

While following the discussion at https://github.com/supercollider/supercollider/pull/5295

Implement BelaServerOptions as a ServerOptions subclass
BelaServerOptions is chosen automatically if Platform.hasBelaSupport
Fix a definition that caused Platform.hasBelaSupport to always return true
Fixed spacing and some other style details in examples

(Tested on both Bela and a Linux host, it works :) )

Types of changes

Bug fix
New feature

To-do list

[ ] Code is tested
[ ] All tests are passing
[ ] Updated documentation
[ ] This PR is ready for review

giuliomoro commented 3 years ago

this looks good to me as far as I can tell ... shall I just add it on top of the upstream PR?

elgiano commented 3 years ago

Thanks! Yeah, isn't this the same branch you created that PR from? Just merging it should update the PR as well, or am I wrong?

giuliomoro commented 3 years ago

yes OK done. I split it into two separate commits :

704bce7fe175cd7a24a4be0cc7caabbe0c086910 c3cebb81094b4ded859d830ef422aaf875772953