Beldex-Coin / beldex

Beldex: the secure, private, untraceable cryptocurrency
https://beldex.io
Other
27 stars 21 forks source link

Too Long Function process_quorums() #68

Closed codeman-crypto closed 2 years ago

codeman-crypto commented 2 years ago

The function process_quorums() in master_node_quorum_cop.cpp#L234 is too long, making it difficult to read and understand. In particular, many (logically) different actions are performed, which could be added into a separate function and called by process_quorums().

chitrasenthil commented 2 years ago

Excelent , great.. Thank you

victor-tucci commented 2 years ago

Since the function process_quorums() is too long. The function can be breakdown into three functions. These functions could have the following names and those are, void quorum_checkpoint_handle(); void handling_master_nodes_states(); void handling_my_master_node_states();
May i proceed with these functions.

codeman-crypto commented 2 years ago

Go ahead.. Make sure it doesn't break the functionality

victor-tucci commented 2 years ago

This breakdown function can increase the readability. Added the pull request #76