Guild showing 0 / 3,000

BelegCufea / PrettyReputation

Simple addon to modify reputation gain messages

https://www.curseforge.com/wow/addons/pretty-reputation

GNU General Public License v3.0

4 stars 0 forks source link

Guild showing 0 / 3,000 #12

Closed Hyphie24 closed 2 months ago

Hyphie24 commented 2 months ago

No lua error, only happening with Guild.

Can test any changes if needed

BelegCufea commented 2 months ago

Thanks for reporting this issue. It may be difficult for me to test it, as I am currently not playing WoW and all my characters are maxed in their guild.

I will try to look into it, though (soon ™).

Hyphie24 commented 2 months ago

Just tell me what you think it may be and I can edit code and try it, have no problem doing that

BelegCufea commented 2 months ago

@Hyphie24 Hi, mate!

First of all, I assume you are in a guild and want to track guild reputation.

Try enabling debug mode (checkbox on the "General" tab) and send me any text that appears in the chat after gaining guild reputation.
Check if you have the "Track" -> "Guild" checkbox checked on the "General" tab (Did I use the word "check" too many times?).
What locale are you using when running WoW? I haven't tried any other than English.

Have a nice day.

Hyphie24 commented 2 months ago

Debug menu enabled, Guild was unchecked, set to "Auto Track", checked the guild box

English locale

The thing I did notice, the guild rep bar is also 0/3000

if I go into the reputation panel, and manually track guild it shows the rep bar like normal

I help maintain the addon "Pretty Reps" and tried to see if there was anything from that to use in this case, but not seeing anything

BelegCufea commented 2 months ago

Thanks for the report. I will look into this.

It seems I need to use the GetGuildInfo API to resolve the guild name. I need to avoid double-dipping into guild reputation changes. Hmm, I will think about it for a bit.

BelegCufea commented 2 months ago

Hello again.

I just pushed a new commit with 3 lines that I hope can do "something" regarding this pesky error.

If you would be so kind, please download the current code and try it.

I don't know exactly what it will do, but I hope it will do "something" :-)

Hyphie24 commented 2 months ago

Will try out this afternoon after work and follow up with it

Hyphie24 commented 2 months ago

HAZZAH! It works!

Thank you so much!

BelegCufea commented 2 months ago

@Hyphie24 Thanks for testing.

It seems there are still some problems with the faction table, but I won't touch it as I will definitely break it. I need to rewrite the guild checks for those who do not want to see guild rep gains.

New version coming soon :-)

BelegCufea commented 2 months ago

OK. Where the hack my last comment from 3 days ago went?

@Hyphie24 Would you be so kind and test the latest commit? I have made some minor changes to the code but can't test it myself.

Just look for any Lua errors :-)

Thank you very much.

Hyphie24 commented 2 months ago

Looks to be working the same, the only difference is if you have "Auto Track" enabled but guild not enabled, the rep bar doesn't change (not sure if this is the intended result, if so then yes working correctly)

BelegCufea commented 2 months ago

Yep, that is intended. My reasoning is that when questing, you may not want to change tracked reputation every time you get some guild reputation.

Well, I will release it in its current state as a new version.

Thanks for reporting and for all the help.