"Script ran too long" error since v1.3.5a

[filliph]

This error is causing cascading failures into other add-ons:

2x PrettyReputation/core.lua:98: script ran too long
[string "@PrettyReputation/core.lua"]:98: in function `saveRepHeaders'
[string "@PrettyReputation/core.lua"]:135: in function `setupFactions'
[string "@PrettyReputation/core.lua"]:639: in function <PrettyReputation/core.lua:636>
[string "=[C]"]: ?
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@BetterWardrobe/Modules/Core.lua"]:1384: in function <BetterWardrobe/Modules/Core.lua:1358>
[string "=[C]"]: ?
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:402: in function `UIParentLoadAddOn'
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:488: in function `RaidFrame_LoadUI'
[string "@Blizzard_RaidFrame/RaidFrame.lua"]:55: in function <Blizzard_RaidFrame/RaidFrame.lua:50>

Locals:
parse = true
collapsed = <table> {
 Inactive = true
}
i = 54250417
name = "Other"
_ = ""
_ = 1
_ = 0
_ = 0
_ = 0
_ = nil
_ = nil
isHeader = true
isCollapsed = false
_ = nil
_ = nil
_ = nil
factionId = nil
(*temporary) = nil
(*temporary) = 270
(*temporary) = "script ran too long"

Example of an error caused by this issue:

2x CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua:66: script ran too long
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <CanIMogIt/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <CanIMogIt/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@BetterWardrobe/Modules/Core.lua"]:1384: in function <BetterWardrobe/Modules/Core.lua:1358>
[string "=[C]"]: ?
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <CanIMogIt/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@CanIMogIt/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <CanIMogIt/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:402: in function `UIParentLoadAddOn'
[string "@Blizzard_UIParent/Mainline/UIParent.lua"]:488: in function `RaidFrame_LoadUI'
[string "@Blizzard_RaidFrame/RaidFrame.lua"]:55: in function <Blizzard_RaidFrame/RaidFrame.lua:50>

Locals:
func = <function> defined @PrettyReputation/core.lua:636
(*temporary) = false
(*temporary) = nil
(*temporary) = "script ran too long"
type = <function> defined =[C]:-1
xpcall = <function> defined =[C]:-1
errorhandler = <function> defined @CanIMogIt/Libs/AceAddon-3.0/AceAddon-3.0.lua:57

[filliph]

Can also confirm that changing local parse = true in core.lua to local parse = false works around this issue.

[BelegCufea]

Thanks for reporting.

I was too overzealous with simplifying some conditions. Reverted them back. I hope this corrects this particular issue.

Version 1.3.5c should be out soon.