Belfast82 / Streamskip

0 stars 0 forks source link

Timespan Modal > Create Add/Edit Entry form #7

Open Belfast82 opened 1 year ago

Belfast82 commented 1 year ago

Description: There needs to be a way to add, edit, and delete timespans. When the user clicks the [Add/Edit] button the main page, the Add/Edit modal wil show. This button should only be available when the user is logged in.

If the user is a non-Admin/Moderator, then the button should only say [Add] If the user is a Admin/Moderator, then the button should say [Add/Edit]

Within the Add/Edit modal, the user can select or create a new category. They may then add a new start HH:mm:ss.SSS (hour:minute:second:millisecond) to the entry. The entry will be manual for now.

The user will then be able to complete the entry by clicking the [OK] button, cancel by [Cancel], or deleting the entry by [Delete] The [Delete] button will only be available for Admin/Moderators and only if the entry is a preiously existing entry.

Acceptance Criteria: The user should be able to select or add a new category. When selecting a category all previously created categories from all videos should be available.

The user should not be able to submit the entry without a category, start, and end time completion. The start and end times must be non-negative number values that must end before the end of the video timespan.

When the user presses the [OK] button, the a valid submission must be accepted and available within the main page. When the user presses the [Cancel] button, then the add/edit modal will be hidden and all entered values will be cleared. When the user presses the [Delete] button, a confirmation will be requested. If [Yes], then the submission will be deleted. If [No], the user will be brought back to the modal.

The modal will close after pressing [OK], [Cancel], or [Delete] (followed by [Yes]).

esaith commented 1 year ago

Get latest from git. Follow the below directions for a reminder. If you have questions please let me know since the directions may need to be updated. https://github.com/Belfast82/Streamskip/wiki/Get-latest-from-Github-and-test-update

With this update, the user will now be able to click the [Add Entry] button. On click, a new modal will show allowing the user to select a category, [Start] and [End] buttons. The category will be hard coded only values. The user should be able to scrub the video in the background to any place in the video and click the [Start] button. The start value should be updated. The user can then play or scrub to the end point then click the [End] button. The end value should be updated.

Clicking the [Ok] button should close the modal, submit the update, and add an entry to the category. Clicking the [Cancel] button should close the modal and have no updates.

Delete has not been added just yet. This will be added in another issue.

Recommended testing

Belfast82 commented 1 year ago

Attempt to submit with no category, start, or end value. Should not add entry. Attempt to submit with category selected, no start or end value. Should not add entry. Attempt to submit with category and start selected, no end value. Should not add entry. Attempt to submit with no category, but selected start and end values. Should not submit. Attempt to submit with no category or start value, but end value. Should not submit.

The five above tests cases failed. Appears there is no validation check after pressing okay.