search

BelfrySCAD / BOSL2

The Belfry OpenScad Library, v2.0. An OpenSCAD library of shapes, masks, and manipulators to make working with OpenSCAD easier. BETA
https://github.com/BelfrySCAD/BOSL2/wiki
BSD 2-Clause "Simplified" License
1.01k stars 115 forks source link

[BUG] egg error when using argument D #1490

Closed gooostaw closed 1 month ago

gooostaw commented 1 month ago

Describe the bug The egg function doesn't work if I use the D argument instead of R.

Code To Reproduce Bug

include <BOSL2/std.scad>
egg(78,d1=50,d2 = 25, D = 100);

Additional context shapes2d.scad line 1475

D = get_radius(r1=R, d1=D)

should be changed to

R = get_radius(r1=R, d1=D)

am I right? ;)

adrianVmariano commented 1 month ago

You're sorta right. There's a second problem. I think it works in the PR.