Belgabor / Magicality

Magicality the Next Dimension, a modpack for Minecraft
1 stars 1 forks source link

Missing emc values #20

Open efeuds opened 9 years ago

efeuds commented 9 years ago

These items don't have emc values right now but seem like they shoud

  1. cobblestone slabs
  2. Many biome's o'plenty items. This includes carrots and berries, moss, ash, mud and likely more.
  3. Witchery seeds don't have emc. I understand if the grown plants don't have it so as to force players to have a witchery garden but this logic wouldn't apply to the seeds.
bengalgod commented 9 years ago

EMC values that would be less than 1 are rounded down to zero. a cobble slab is half of a cobble, and cobble has an emc of 1. Hence no EMC.

I could have sworn we sorted the EMC values for witchery seeds, but we'll double check. The seeds are definitely meant to have an EMC.

The big problem with BoP items is there are so many of them, and so many of them must be entered manually. If you want to submit a numbered list, I'll see how many we have the patience to input for the next version.

On Mon, Dec 29, 2014 at 12:52 PM, efeuds notifications@github.com wrote:

These items don't have emc values right now but seem like they shoud

  1. cobblestone slabs
  2. Many biome's o'plenty items. This includes carrots and berries, moss, ash, mud and likely more.
  3. Witchery seeds don't have emc. I understand if the grown plants don't have it so as to force players to have a witchery garden but this logic wouldn't apply to the seeds.

— Reply to this email directly or view it on GitHub https://github.com/Belgabor/Magicality/issues/20.

efeuds commented 9 years ago

Huh, never thought of that with the cobblestone slabs. As for the BoP thing if its too much of a hassel I wouldn't worry about it. I don't really need it that much but I just thought you would want to know. Maybe the seeds are an error on my end, my game says magicality aspha 1.0 even though I updated to 2.0. It could be that you added emc values to seeds in 2.0 but for some reason I am unable to upgrade to 2.0 (or maybe there is just a small but where the version number is wrong).

bengalgod commented 9 years ago

This is actually an issue with the way ATL updates scripts in modpacks. You can fix this by performing a clean install of the pack, but you would lose your old world.

On Mon, Dec 29, 2014 at 1:17 PM, efeuds notifications@github.com wrote:

Huh, never thought of that with the cobblestone slabs. As for the BoP thing if its too much of a hassel I wouldn't worry about it. I don't really need it that much but I just thought you would want to know. Maybe the seeds are an error on my end, my game says magicality aspha 1.0 even though I updated to 2.0. It could be that you added emc values to seeds in 2.0 but for some reason I am unable to upgrade to 2.0 (or maybe there is just a small but where the version number is wrong).

— Reply to this email directly or view it on GitHub https://github.com/Belgabor/Magicality/issues/20#issuecomment-68282354.

haighyorkie commented 9 years ago

actually it's my fault, I never changed the config file to say Alpha-2.0. It will of course be fixed in the next version :)

efeuds commented 9 years ago

Ahh, unfortunately though that means the missing emc values for witchery seeds is probably not due to me having the wrong version.

Belgabor commented 9 years ago

I've added a couple of missing EMC values for Alpha 3.0, including most Witchery crops