API: add a filter method to DwCAReader that returns all lines that match some criteria...

BelgianBiodiversityPlatform / python-dwca-reader

🐍 A Python package to read Darwin Core Archive (DwC-A) files.

BSD 3-Clause "New" or "Revised" License

43 stars 21 forks source link

API: add a filter method to DwCAReader that returns all lines that match some criteria... #11

Closed niconoe closed 8 years ago

niconoe commented 11 years ago

Take example on Django's ORM
Define the filter parameter structure and capabilities (should we also filter by extensions?)

niconoe commented 8 years ago

Notes from duplicate ticket:

Proposal 1) DwCAReader.filter_lines(params), with params similar to get_line() method ? Proposal 2) DwCAReader.lines.filter(params) (better separation of concern) Proposal 3): both, 1) being an alias to 2) ? Something else ?

niconoe commented 8 years ago

Hmmm, is that really desirable?

That add "weights" to the library.
That's easily implemented by consumers (conditional after iterating on all rows)
Unlike the ORM example, it won't allow better performances (there's no backend to propagate the filter to)