What happens when we provide incorrect input to extensions_to_ignore ?

BelgianBiodiversityPlatform / python-dwca-reader

🐍 A Python package to read Darwin Core Archive (DwC-A) files.

BSD 3-Clause "New" or "Revised" License

43 stars 21 forks source link

What happens when we provide incorrect input to extensions_to_ignore ? #42

Closed niconoe closed 8 years ago

niconoe commented 9 years ago

Currently, it's undocumented and it (silently) does nothing.
Better: it should throw an exception
This should be documented
This should be tested

niconoe commented 8 years ago

Hmmm, is it really worth adding code to check this parameter and throw an exception in this case? Keeping it like that is sometimes more flexible for users, too (they can pass several archives of unknown formats, and just ask to ignore extension if present).

Let's sleep one more time on it, keeping it like that may be the solution.

Add a test to ENSURE nothing happens when the file is not present, and document the behavior may be good?