Fix issue with CSV fields that contain field-ending character.

BelgianBiodiversityPlatform / python-dwca-reader

🐍 A Python package to read Darwin Core Archive (DwC-A) files.

BSD 3-Clause "New" or "Revised" License

43 stars 21 forks source link

Fix issue with CSV fields that contain field-ending character. #70

Closed bcail closed 6 years ago

bcail commented 6 years ago

Refactor parsing the raw field data into a method. Add a test with field data that contains the field-ending character. Fix the issue by using the CSV reader object.

niconoe commented 6 years ago

Thanks a lot @bcail, that's great! Just a couple of remarks before I merge this:

Don't hesitate to add you to AUTHORS
It would be great to have a high-level test case that shows exact issue solved (fail before/pass after). I guess it's done in test_get_raw_fields, but I cannot run it on the old codebase since it relies on the new get_raw_fields method.

Thanks again for your help!

bcail commented 6 years ago

@niconoe updated.

niconoe commented 6 years ago

Brilliant, thanks for your contribution!