search

BelkacemYerfa / shadcn-extension

An open source component collection , that extends your ui library , built using shadcn component
https://shadcn-extension.vercel.app/
MIT License
695 stars 22 forks source link

FIX: Carousel SliderMainItem children components not handling onKeyDown events #53

Closed FlorianMgs closed 4 months ago

FlorianMgs commented 4 months ago

Move event.preventDefault(); into the case statements. Before that, inputs nested under a SliderMainItem were not receiving pressed keys.

BelkacemYerfa commented 4 months ago

Hello @FlorianMgs !

Thank you for addressing this issue for bringing this into our attention, the fix that you made is good, as a consequence you PR will get merge into the dev branch.

As a result this fix will be landed in the next release.

Welcome to contribution club , as a contributor 💪. Don't forget to spread the word on Reddit or similar. Enjoy 🎉!