search

Bella-DeFinTech / uniswap-v3-simulator

the "Tuner", a Uniswap V3 Simulator
https://docs.bella.fi/
Other
144 stars 45 forks source link

Refactor user interface #55

Closed kafeikui closed 2 years ago

kafeikui commented 2 years ago

Now you can download or update events and build the ConfigurableCorePool instance from arbitrary pool on mainnet, at any block tag with any RPCProvider.

TODO:

  1. A way to at least skip issue #54 . Pool with not so much liquidity might confront an error during a series of extreme swaps.
  2. backtest reference: Uniswap-v3-bot (as user integration example)
neptune-v commented 2 years ago

The interface abstraction of "SQLiteDBManager" seems missing the point because it's used internally, and it's less likely users would provide their own implementations than "EventDBManager" which is used to feed the data.

Not a high priority because we are pre-processing the data, and it's hard for the user to provide their own implementations of "EventDBManager" anyway.

However, I suggest changing the name "DBManager" interface into "InternalDBManager" or "SimulationDataManager", it is too general.

kafeikui commented 2 years ago

The interface abstraction of "SQLiteDBManager" seems missing the point because it's used internally, and it's less likely users would provide their own implementations than "EventDBManager" which is used to feed the data.

Not a high priority because we are pre-processing the data, and it's hard for the user to provide their own implementations of "EventDBManager" anyway.

However, I suggest changing the name "DBManager" interface into "InternalDBManager" or "SimulationDataManager", it is too general.

Sure, I have renamed "DBManager" interface and its SQLite implementation, later we can talk about how to add interface for EventDBManager.