search

BelledonneCommunications / bctoolbox

Linphone.org mirror for bctoolbox (git://git.linphone.org/bctoolbox.git)
http://linphone.org
GNU General Public License v3.0
25 stars 33 forks source link

Fixed: configuration file reading on windows #2

Open wdigger opened 8 years ago

bagage commented 8 years ago

Thanks for your pull request @wdigger! Just a question: in which case would you have file lines ending with \n\r or \r only? Because it seems to me that this is what your PR is solving, right?

wdigger commented 8 years ago

On windows (VS 2015) read(...) from file opened in text mode removes all '\r' symbols from result buffer (size of result really smaller then real file size), but leaves garbage (uncleaned content with '\r\n') in the buffer end.

In fact error is occurred in other place, you may reject this request or i may to modify it with fix of bcRead.

wdigger commented 8 years ago

String truncated with size of really readed data.