BelledonneCommunications / linphone-android

Linphone.org mirror for linphone-android (https://gitlab.linphone.org/BC/public/linphone-android)
https://linphone.org
GNU General Public License v3.0
1.12k stars 688 forks source link

Problem after recompiling linphone-android-sdk #907

Closed Nicolo-sudo closed 4 years ago

Nicolo-sudo commented 4 years ago

Hi there!

I have build my own version of the linphone sdk for android. I wanted to enable the H263 codec, so I recompiled the sdk by passing the -DENABLE_FFMPEG=ON and an .AAR file was built successfully. So I have replaced the previous sdk with my own in the Linphone Android Project. The problem is that in the video settings of the app there are only the H264, H265 and VP8 codecs. Why there isn't the H263 codec?

Thanks in advance

Viish commented 4 years ago

Hi, Please attach logs from the libs and I'll be able to tell you why.

Nicolo-sudo commented 4 years ago

Do you mean the logs of the shell? Because I lost them when I close the window.. I probably need to recompile the sdk again.

After the compilation I found the file wich I have attached. But seems that h263 is not present

disabled_features.txt enabled_features.txt

Thank you for your help

Viish commented 4 years ago

No I'd like the logs of the app. Go into settings->advanced and toggle Debug switch. Then restart the app, go to the About page and click on Upload logs.

Nicolo-sudo commented 4 years ago

Alright, so tomorrow I will try and I will let you know!

Thank you again for your attention

Nicolo-sudo commented 4 years ago

Hi, I have attached the library logs.

5e3136566c2fb_3739ecc91f96b458c83e.txt

What I have done:

 -DLINPHONESDK_PLATFORM=Android -DENABLE_FFMPEG=ON 
-DENABLE_NON_FREE_CODECS=ON

ln -s /linphone-sdk/build/linphone-sdk/bin/outputs/aar/linphone-sdk-android-release.aar linphone-sdk-android/linphone-sdk-android-release.aar

This procedure is correct or I have made some mistakes?

Viish commented 4 years ago

Yes this is perfectly right. Did you also add to the cmake options -DENABLE_H263=ON ?

Nicolo-sudo commented 4 years ago

No, as said here (#821 ) i also add -DENABLE_FFMPEG=ON.

I will try again to rebuild the sdk with this option

Thanks

Nicolo-sudo commented 4 years ago

Hi, nothing changed still no H263 codec

Viish commented 4 years ago

Can you add new logs?

Also, after the cmake command, do you see H263 in the enabled features list?

Nicolo-sudo commented 4 years ago

I have made few tests.

If I build with -DENABLE_H263= ON and -DENABLE_FFMPEG=ON the compilation fails after few seconds:

crash_compiling.txt

So I built the new sdk with this options:

cmake -DLINPHONESDK_PLATFORM=Android -DLINPHONESDK_ANDROID_ARCHS=arm64 -DENABLE_NON_FREE_CODECS=ON -DENABLE_H263=ON ..

Unfortunately again there is no H263 feature in this new files:

disabled_features.txt enabled_features.txt

I really need this codec but no luck

Viish commented 4 years ago

You need all those params: -DENABLE_NON_FREE_CODECS=ON -DENABLE_H263=ON -DENABLE_FFMPEG=ON

Nicolo-sudo commented 4 years ago

Okay but the compilation fails if I use all these options together. From logs seems that fails with this error:

No download info given for 'EP_ffmpegandroid' and its source director

To get the SDK sources I used the given git command:

git clone https://gitlab.linphone.org/BC/public/linphone-sdk.git --recursive

Probably is something wrong with my configuration? But why in other cases everything goes fine?

Thank you very much for your help

Viish commented 4 years ago

No, sadly you are in the current case where ffmpeg doesn't build anymore (I guess you have a recent NDK). We have no plan to make it work again for now, but if you manage I'll gladly merge a patch.