BelledonneCommunications / linphone-desktop

Linphone is a free VoIP and video softphone based on the SIP protocol. Mirror of git://git.linphone.org/linphone-desktop.git
https://linphone.org/
GNU General Public License v3.0
408 stars 207 forks source link

[Bug]: Storing a SIP contact should not store the server you connect with #737

Open reubenfirmin opened 1 year ago

reubenfirmin commented 1 year ago

Context

Personal usage, with voip.ms as a provider

General information

Expected behaviour

Voip.ms offers different servers to register with, so that you can use a server closest to you and reduce latency.

You can only register with one server at a time, however the same credentials apply to any server.

When I store a contact, the server information is stored along with the contact's phone number; this is a bug. The identifying part of what is stored is the phone number of the contact; the SIP server that I used is the transport layer that was used in order to contact them.

This would be analagous to storing email contacts as: bob@gmail.com@deutchetelekom.

The problem with doing this is that if I click on a contact when registered with a different server than the contact was saved with, linphone pops up the authentication UI (which is a) more friction than is necessary when making a call; b) is difficult because I generated a relatively complex password which I don't have memorized).

Granted that some contacts will be specific to some SIP providers (e.g. internal contacts in a corporate network) but the vast majority of contacts will have POTS telephone numbers.

I think there are two fixes needed here: a) Most importantly, distinguish "internal" and "external" contacts b) Allow multiple servers for a SIP provider to be specified, and the same credentials to be specified across them

To Reproduce

Use any SIP provider that supports multiple servers, as described above.

Additional context

No response

SDK logs URL

No response

pixelstuff commented 12 months ago

Was this ever fixed? Because I can't even figure out how to add a contact. I assume it must be related to this bug.

Aside from the bizarre decision for a phone app to not have a phone number field in the contacts list, any phone number I type into the SIP Account(s) field just disappears when I click off. If there is some special technique, I can't find a help file to spell it out.