search

BelledonneCommunications / linphone-desktop

Linphone is a free VoIP and video softphone based on the SIP protocol. Mirror of git://git.linphone.org/linphone-desktop.git
https://linphone.org/
GNU General Public License v3.0
391 stars 200 forks source link

Unnecessary git submodule? #840

Closed daniel7558 closed 2 weeks ago

daniel7558 commented 1 month ago

Hi all,

I noticed that one of the top-level submodules (plugins/contacts/contacts-api) seems to require credentials to clone. When initializing the submodules, git will ignore submodules that it cannot access, i.e. this one does not get cloned when running git submodule update --init --recursive and its folder remains empty.

Should this module be removed or is there a special purpose for it? (It builds fine without the submodule)

[submodule "plugins/contacts/contacts-api"]
        path = plugins/contacts/contacts-api
        url =  https://gitlab.linphone.org/BC/public/linphone-desktop-plugins/contacts/contacts-api.git

Cheers

Ledjlale commented 2 weeks ago

Hi, thanks for your report. This repo is not private. It just doesn't exist. I updated the .modules file in master Regards