Refactored code base

[jonathanwindle-zz]

Original Message

This pull request includes a refactored code base, resulting in more modularized code. It also includes changes previously submitted in pull request #54.

Update

This is a rebase of pull request #57. Duplicate changes with different commit ids have been removed. Additionally I removed unnecessary merge commit messages.

[jonathanwindle-zz]

Still receiving the following message from WordPress when activating the plugin.

The plugin generated 2 characters of unexpected output during
activation. If you notice “headers already sent” messages, problems with
syndication feeds or other issues, try deactivating or removing this
plugin.

I saw the following message from @shawn-bellevuecollege

FYI, I've been seeing this warning since I started working on this
project. It doesn't appear to be a standard PHP error, and the wording
seems to imply that it's not something to be overly concerned about
unless other issues are observed.

I will do some retroactive testing against what is in mainline dev to see if the message shows up from that code base as well. This is something that will need fixing or a better explanation before release.

[jonathanwindle-zz]

Password for LDAP service account password still shows up in the CAS Settings HTML. I believe this was fixed or attempted to be fixed in commit f3dbf52d416a1a5119409218cdf7c43c40fae8cf. It got merged back in on commit 854342d846d74b0c3b58e7a438e7a64944c12eef when the html output was moved to file cas-client-ui.php

I will attempt to resolve this issue myself.

[jonathanwindle-zz]

Amended commit 854342d846d74b0c3b58e7a438e7a64944c12eef and removed the following line from cas-client-ui.php

<!-- <input type="password"  name="wpcasldap_ldappassword" id="ldap_password_inp" value="<?php echo $optionarasldap_ldappassword" id="ldap_password_inp" value="<?php echo $optionarray_def['ldappassword']; ?>" /> -->

This has resolved the issue of displaying the password in the CAS Settings html. Commit 854342d846d74b0c3b58e7a438e7a64944c12eef has changed to 6fb53b5dea23b6661365949ced973e6109a92099

[jonathanwindle-zz]

I confirmed that the message about 2 characters of unexpected output did not originate from this pull request and is currently a problem in the dev branch. Our last stable release of v1.2.1.0 does not have this problem so this was introduced somewhere in Sprint 2.

I have filed bug #59 for this issue to be resolved.

Pull request is approved for merge.