Belval / pdf2image

A python module that wraps the pdftoppm utility to convert PDF to PIL Image object
MIT License
1.51k stars 187 forks source link

Remove posix import #250

Closed Belval closed 1 year ago

Belval commented 1 year ago

Fixes: #249

Unused imported was added in 1.16.1. Also need to pull the release and remove the version from PyPI.

Will need to investigate why the CI didn't raise and issue.

codecov-commenter commented 1 year ago

Codecov Report

Base: 96.09% // Head: 96.07% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (233bb08) compared to base (34d3461). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #250 +/- ## ========================================== - Coverage 96.09% 96.07% -0.02% ========================================== Files 5 5 Lines 307 306 -1 ========================================== - Hits 295 294 -1 Misses 12 12 ``` | [Impacted Files](https://codecov.io/gh/Belval/pdf2image/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edouard+Belval) | Coverage Δ | | |---|---|---| | [pdf2image/pdf2image.py](https://codecov.io/gh/Belval/pdf2image/pull/250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edouard+Belval#diff-cGRmMmltYWdlL3BkZjJpbWFnZS5weQ==) | `95.31% <ø> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edouard+Belval). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edouard+Belval)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Belval commented 1 year ago

Tested on Windows, there are still two tests failing:

tests.py::PDFConversionMethods::test_conversion_from_pathlib_path_using_dir tests.py::PDFConversionMethods::test_conversion_from_pathlib_path_using_dir_14

I will be opening an issue but I think in the meantime this is good to go.