convert_from_bytes has wrong argument name or docstring - Githubissues

Belval / pdf2image

A python module that wraps the pdftoppm utility to convert PDF to PIL Image object

MIT License

1.51k stars 187 forks source link

convert_from_bytes has wrong argument name or docstring #253

Open t-ae opened 1 year ago

t-ae commented 1 year ago

First argument of convert_from_bytes is pdf_file. https://github.com/Belval/pdf2image/blob/d415156659f76f898ff2d5c9e2884212ee7fac76/pdf2image/pdf2image.py#L277

Its docstring calls it pdf_bytes. https://github.com/Belval/pdf2image/blob/d415156659f76f898ff2d5c9e2884212ee7fac76/pdf2image/pdf2image.py#L302

pdf_bytes sounds more accurate for me, but renaming can break compatibility.