search

Belval / pdf2image

A python module that wraps the pdftoppm utility to convert PDF to PIL Image object
MIT License
1.51k stars 187 forks source link

Missing py.typed file #255

Closed PedroPerpetua closed 1 year ago

PedroPerpetua commented 1 year ago

Type annotations were added in commit aa6aee8bcd9da84a4f5b5dc1614fb6e200228d0d seem to be complete, but linters like MyPy still shoot out an error due to no py.typed file being present when installed trough pip.

More details can be found here: https://mypy.readthedocs.io/en/stable/running_mypy.html?highlight=py.typed#missing-library-stubs-or-py-typed-marker

Simply adding a py.typed file to the pip packaging should fix the issue.

Belval commented 1 year ago

I am unfamiliar with py.typed, but I don't see any reason to not add it. I'll see if I get around to doing it otherwise feel free to submit a PR.

PedroPerpetua commented 1 year ago

@Belval here's the relevant PEP: https://peps.python.org/pep-0561/#packaging-type-information

PedroPerpetua commented 1 year ago

PR opened: #256

PedroPerpetua commented 1 year ago

Closed with #256