search

Ben-Hanan / pe

0 stars 0 forks source link

Example in edit expense in UG does not really make sense. #4

Open Ben-Hanan opened 3 years ago

Ben-Hanan commented 3 years ago

Nitpicking but Shopee internship should not be an expense but an income instead in the example given. This could mislead and confuse users

image.png

nus-se-bot commented 3 years ago

Team's Response

Firstly, I think Shopee Internship can be an expense, as it is up to the discretion of the user. For instance, an intern planning an event is meant to buy items worth up to $2000 prior to the event and will be reimbursed by the Finance department post internship. Hence at that point in time, this is considered an expense which is due to their internship role at Shopee.

Secondly the example is meant for users to just use as a reference on how the command format is and what fields are required for the command to be successfully executed. The image below shows the command format for editing an expense:

Screenshot 2020-11-16 at 10.06.50 PM.png

The command format states that to edit an expense successfully, you need to add in the various inputs fields and some of the input fields are optional. We feel that this bug does not confuse the user because the example you have pointed out can actually still be executed successfully and the behaviour will be still be correct because Shopee Internship is a valid TITLE.

The content of the example command does not affect usage because there are other examples as reference as well. Furthermore , this bug does not affect normal operations of the product as well.

Overall, we think that an example is just meant to give the user a reference on how the command format is like and what are the various command formats available. The content of the input is not so very important because in the end, it is up to the user discretion on what they plan to input as a title, if they wish to, when they want to edit an expense. Therefore we feel that this bug should be rejected.

We have lowered the severity of the bug from Low to VeryLow because it does not affect normal operations of the product due to the reasons we have explained.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your reason]