Closed xavierhardy closed 4 years ago
As I said last week, it was a class I created following this Spring.io guide : https://spring.io/guides/gs/accessing-data-mysql/ . I just wanted to try if something other than "YO!" could be displayed on a simple way. it's never been a working class (hero), and has never found its "raison d'être". I've always wanted to remove it.
There are several things wrong with the
PeopleController
.Request parameters (a.k.a. query parameters) are the
&
-separated arguments you pass in the URL (after?
)Here
something
andother
would be the request parameters. Usually, API routes expecting thePOST
HTTP verb are expected to contain their arguments in the content (also called body) in a serialized form (e.g. most commonly today: JSON). Apparently, request parameters can also be used when sending FORM content (which is not much used in modern service AFAIK).The
People
methods used here are undefined.Nitpicking: the controllers should be in a separate package (e.g.
controller
). As they are probably annotated with@Controller
, their current location is not a problem, but it's inconsistent.The whole concept of having the user add character themselves make little sense to me, unless this is meant for administrators only or a game editor, which brings me back to the problem of defining the project scope and requirements.