search

Ben-Xav / holycraap

BACKEND In search of the one and only Holy Craap - a treasure also known as "Big Whoop(TM)" - a new adventure game written in Java and JavaScript, using Spring and React.
GNU General Public License v3.0
1 stars 0 forks source link

Controllers #28

Closed BenMorant closed 4 years ago

BenMorant commented 4 years ago

I created a branch called controllers in order to try to code one controller + I modified the test accordingly . Of course I would need to test the other methods of the controller class, and also to create other controller classes, but it's one step towards our goal .

xavierhardy commented 4 years ago

LGTM, please fix the 2 minor comments, it would have been better with tests though.

BenMorant commented 4 years ago

LGTM, please fix the 2 minor comments, it would have been better with tests though.

Super. Yes, sure... tests. Haven't had the time to dig into those yet.

BenMorant commented 4 years ago

I guess I can close that now (even if I opened it)