Closed Ben1152000 closed 1 year ago
Looks good to me, fixed a small bug in the reloading part, functionality wise it's perfect. Also really like the new dict representation in the save file!
However I do think the old date format would be preferred for most usecases?
I also think providing absolute path would be better as that would allow us to reload from anywhere in the directory tree, will push a fix for that.
Pushed the fix and tested functionality, would like your opinion on the date format!
However I do think the old date format would be preferred for most usecases?
I went with the unix timestamp since it's very easy to compare two values. I'm not sure if there are any weird issues when comparing dates, but if you think it's better to have readability feel free to change it.
I also think providing absolute path would be better as that would allow us to reload from anywhere in the directory tree, will push a fix for that.
Agreed, this behavior seems more reasonable.
However I do think the old date format would be preferred for most usecases?
I went with the unix timestamp since it's very easy to compare two values. I'm not sure if there are any weird issues when comparing dates, but if you think it's better to have readability feel free to change it.
I also think providing absolute path would be better as that would allow us to reload from anywhere in the directory tree, will push a fix for that.
Agreed, this behavior seems more reasonable.
I think the unix timestamp is fine as well, not an issue per se. Will solve conflicts and approve.
This PR contains the following changes:
sootty filename.vcd
instead ofsootty -f filename.vcd
)-d
display argument with-o
output (which does the opposite)