search

BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
286 stars 112 forks source link

Feature/captain mode #127

Closed BenBrostoff closed 5 years ago

BenBrostoff commented 5 years ago

Putting this PR out so we're both aware of branch status. This is good to go I think 👍 . @sharkiteuthis - take a look and tell me what you think. The big change here was to build in solver_id based locking and banning. I personally use this a lot in showdown (mainly wanting to ban a top player from captain but keep them at flex).

I did not add any exposure controls for this feature but figure we can do that later.

BenBrostoff commented 5 years ago

@sharkiteuthis Did a release that has this code but I'll hold off a few days just so you can take a look if you have time before merging to master.

BenBrostoff commented 5 years ago

@sharkiteuthis Going to merge this - definitely push back with PRs / issues if any of it seems unreasonable.

sharkiteuthis commented 5 years ago

This all looks good. I'm not happy with multi-position players in general, but that makes sense -- all players are effectively mutli-position in a showdown slate. I have a branch checked out to work on that.