search

BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
286 stars 112 forks source link

[Question] Numpy version requirement #172

Closed dttyszka closed 9 months ago

dttyszka commented 3 years ago

New to this repo, but find the code very useful! I did notice the numpy version requirement==1.15.4, and this prevents pandas and draftfast from co-existing in the same env. What drives the requirement on that version of NumPy?

Thanks in advance!

BenBrostoff commented 3 years ago

Nothing as far as I know - upgrading is probably fine here, I will take a look tomorrow - thanks for catching!

On Wed, Jan 20, 2021 at 10:42 PM dttyszka notifications@github.com wrote:

New to this repo, but find the code very useful! I did notice the numpy version requirement==1.15.4, and this prevents pandas and draftfast from co-existing in the same env. What drives the requirement on that version of NumPy?

Thanks in advance!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BenBrostoff/draftfast/issues/172, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVK35C3MIYTHKW3PG4ENT3S26PBPANCNFSM4WMCDJBQ .

BenBrostoff commented 3 years ago

@dttyszka I haven't had time to work on this but will gladly accept a PR if it passes the build!

BenBrostoff commented 9 months ago

numpy is now on 1.24 and intending to keep upgrading, going to close here.