search

BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
277 stars 113 forks source link

Add new constants directory to hold rule configurations #211

Closed npinciak closed 6 months ago

npinciak commented 6 months ago

I think we could organize the rules a little bit better by introducing a directory that holds all of the static/constant rule configurations.

This is request does not modify any existing imports or logic that affects the package. This just adds new files to be used in followup pull requests

BenBrostoff commented 6 months ago

Looks great! Thank you for the PR.

BenBrostoff commented 6 months ago

If you don't mind just fixing the unused imports from https://github.com/BenBrostoff/draftfast/actions/runs/7263813162/job/19803128017?pr=211 that would be awesome. If they're just imported to be exposed I'm fine doing the assert <module> solution

BenBrostoff commented 6 months ago

Thanks again! Future PRs good anytime :-)