search

BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
287 stars 113 forks source link

small orm change #25

Closed kacperadach closed 8 years ago

kacperadach commented 8 years ago

just moved repr to after init to group built-in methods and added a method that checks if two rosters are identical

BenBrostoff commented 8 years ago

Power play request alert - can you write a test for this one? Should be pretty easy in tests.py / you can run the tests via nosetests.

kacperadach commented 8 years ago

Right away boss!

BenBrostoff commented 8 years ago

Get ready for another you're going to hate me comment - is it possible for you to just overwrite the __eq__ built-in method? That way you can literally do roster_1 == roster_2 instead of calling a named method.

BenBrostoff commented 8 years ago

Also I nominate this as the official video of "I hate this code review comment.".

kacperadach commented 8 years ago

nah that makes perfect sense, didnt know that was a built in

kacperadach commented 8 years ago

Love the school of Brostoff

BenBrostoff commented 8 years ago

@kacperadach you the man image