search

BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
287 stars 113 forks source link

Scrape all #28

Closed kacperadach closed 7 years ago

kacperadach commented 7 years ago

for me to just run the scrape.py script and get all the csvs I need to add to dk_files

kacperadach commented 7 years ago

I dont know why the tests are failing, any idea?

BenBrostoff commented 7 years ago

@kacperadach Think this is related to how the Dockerfile is written (notice how the error is No module named dk) - the working directory it creates is called dk (and the tests run in a Docker container on Travis). You could try changing the Dockerfile to name the repo draft_kings_fun.

BenBrostoff commented 7 years ago

@kacperadach I think this one is annoying because I named this repo draft-kings-fun - I never considered using it as a submodule at the time I made it. We have a couple options - check out this S/O thread for how to import a module under a directory with dashes.

If you want to make these changes, I'm fine with merging them (I don't want to change the name of the repo at this point). If you don't, we can keep using that one branch for submodule use.

BenBrostoff commented 7 years ago

Closing because of all the issues we discussed / this is way behind master now. Definitely down to revisit at later point in time.