BenBrostoff / draftfast

A tool to automate and optimize DraftKings and FanDuel lineup construction.
282 stars 112 forks source link

Convert to pip module #90

Closed BenBrostoff closed 5 years ago

BenBrostoff commented 5 years ago

This PR will address #63 . I've published a version (1.0.0) to pip. I'm putting my TODO list here so people can follow along as this gets developed:

Not completed, okay to move to issues:

@sharkiteuthis - this isn't ready yet but I'm hoping to finish in the next few days. If you're working on other branches it may be useful to periodically pull from this branch. I've released 1.0.0 and even though this is a little rough around the edges, I think we should merge to master so working on feature branches is easier. The three things that are core functionality that are not in the exposed library right now are 1) uploading CSVs to DraftKings / FanDuel and 2) exposure work you completed (it's there actually but not documented or tested) and 3) pick em optimizer for DraftKings. I can create issues for all three.

I invited you to the repo so you can have review access - let me know if you didn't get it 👍

UPDATE - you can experiment with the exposed module on repl.it here

sharkiteuthis commented 5 years ago

let me know when you want me to review

BenBrostoff commented 5 years ago

Will do, this might take a few days because the API is changing in a significant way.

sharkiteuthis commented 5 years ago

What are these items?

  • Expose rules
  • Allow option to control flex position (blacklist or whitelist)
  • Allow user to pass in custom functions for player pool

Do you mind explaining what you have in mind here? Is there overlap with #94?

BenBrostoff commented 5 years ago

Ah that’s my fault, I didn’t see 94. The flex is overlap but the rules just refer to objects that contain data on salary cap / roster size / etc based on the sport and site. The custom function is a way to filter the players by some arbitrary condition like has an average of at least 10 points or is on the Clippers but is not a PG.

On Tue, Nov 27, 2018 at 11:47 AM Tom Dodson notifications@github.com wrote:

What are these items?

  • Expose rules
  • Allow option to control flex position (blacklist or whitelist)
  • Allow user to pass in custom functions for player pool

Do you mind explaining what you have in mind here? Is there overlap with

94 https://github.com/BenBrostoff/draftfast/issues/94?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BenBrostoff/draftfast/pull/90#issuecomment-442152410, or mute the thread https://github.com/notifications/unsubscribe-auth/AGqt9J_oAkFEWJeCe9i9y7lr6iOiMRrDks5uzXqggaJpZM4YyGv0 .

sharkiteuthis commented 5 years ago

I like the rules idea. In general I don't stack QB/RB unless it's Dak/Zeke, Jackson/Edwards, or Cam/CMC. It would be cool to handle that with a single rule instead of having to write 29 groups

BenBrostoff commented 5 years ago

@sharkiteuthis Ugh, this is a Python 3.5 thing. I'm upgrading the Dockerfile to Ubuntu 17.10 which I think uses 3.6 by default, will see if that resolves.

BenBrostoff commented 5 years ago

Also the Travis build is no longer triggering. I think this is related to them deprecating travis-ci.org... not worrying about it for now.

BenBrostoff commented 5 years ago

Okay @sharkiteuthis , once you approve this I'll merge in 👍 . Added the issues you mentioned.

sharkiteuthis commented 5 years ago

building the new docker image, numpy takes forever on my laptop

sharkiteuthis commented 5 years ago

works for me