search

BenChung / KRPC.jl

A kRPC client for Julia
MIT License
3 stars 4 forks source link

make_error does not exist when decoupling a separator #15

Closed Rhahi closed 2 months ago

Rhahi commented 1 year ago

I am imagining that this comes from the old code, and it's probably just replaced by error().

In raw.jl, there are 5 instances of throw(make_rror(...)). There seems to be no such function that exists within KRPC.jl.

This function can be called when decoupling a separator (but not decoupler) using Decouple() function in Vanilla.

parts = SCH.Parts(sp.ves)
dec_part = SCH.WithTag(parts, "sep")[1]
dec = SCH.Decoupler(dec_part)
SCH.Decouple(dec)

UndefVarError: `make_error` not defined

Stacktrace:
 [1] SendBiMessage(conn::KRPC.KRPCConnection, req::KRPC.krpc.schema.Request)
   @ KRPC ~/.julia/dev/KRPC/src/raw.jl:38
 [2] macro expansion
   @ ~/.julia/dev/KRPC/src/message.jl:44 [inlined]
 [3] kerbal(c::KRPC.KRPCConnection, calls::Tuple{KRPC.Interface.SpaceCenter.Decoupler_Decouple})
   @ KRPC ~/.julia/dev/KRPC/src/message.jl:40
 [4] kerbal
   @ ~/.julia/dev/KRPC/src/message.jl:14 [inlined]
 [5] Decouple(this::KRPC.Interface.SpaceCenter.RemoteTypes.Decoupler)
   @ KRPC.Interface.SpaceCenter.Helpers ~/.julia/dev/KRPC/src/generated.jl:12953
 [6] top-level scope
   @ ~/.julia/dev/SpaceLib/livetest/src/explore.ipynb:1