Cumulative bug fixes - Githubissues

Rhahi commented 1 year ago

Another set of bug fixes!

Closes #16 Closes #15 Closes #12

Performance

some functions were trying to use this when it does not exist. This should fix them. c8ac069b3a9d2a130e4256c3e39de9398d4bcea9. Closes #12
add import for missing getJuliaValue, which some methods needed. 3a7828f601c33ba50e19a09da40ca1e418550c3c

error found during code review. Probably does not fix any real bug. 3a52bee1b496a5bdb115b26196b46bff0fd1999b
use error instead of make_error that does not exist 1d775ba00485c397d8d5c9936d375cbc2a38f033 116f9a044294f228e0139004f24205eebd42d075. Closes #15, but it probably won't fix the originating exception on decoupling a separator.
fix a bug preventing creating remote objects with ID higher than 127. Closes #16 6b72a4747f717c8ce3e827eefa66fcc3d2200090

Rhahi commented 1 year ago

Found an issue with this fix, will come back with a fix.

Rhahi commented 1 year ago

I am not certain if only the ID should use write_varint, or all integers should use write_varint yet.

BenChung commented 1 year ago

I think that all integers should use write_varint - do you mind if I merge this now?

I'm planning to tag another release after I can fix the enum issue you identified, hopefully by the end of the week.

Rhahi commented 1 year ago

I think it should be fine to merge, but for another release I suggest giving a week so that I can test the affected features in both vanilla/RO.

Rhahi commented 1 year ago

I've done some tests in vanilla and haven't found any obvious mistakes with code generation -- that is, I can change scenes and load saves.