BenCodez / GraveStonesPlus

5 stars 2 forks source link

Nasty Case: Waterfall and Gravestones #2

Closed Hershbja closed 2 years ago

Hershbja commented 2 years ago

I found a nasty case where when one of my players "out ran" the water fall and died from falling damage. Then the waterfall "washed" the grave's head away. Making the grave invalid and the player losing their items.

Washing the grave away: The head pops off from the flowing water. Invalidating the grave.

BenCodez commented 2 years ago

https://bencodez.com/job/GraveStonesPlus/ this better?

Hershbja commented 2 years ago

https://bencodez.com/job/GraveStonesPlus/ this better?

Okay so now that the head pops off it removes the grave, good for removing the invalid grave. REALLY sucks for the player (Lose everything).

Is there any way to make it so the head doesn't pop off to invalidate it? It doesn't do this when there is "Stagnant" waterfall (Like when they drown going up a water fall that has already been there.) If not possible then that's okay, i'll just warn them to not outrace an "actively flowing" waterfall.

PS: This plugin is really awesome and really useful (We have a few players that can't seem to stay alive) and you're quick with bug issues. I like that, please keep up the good work.

BenCodez commented 2 years ago

Does it work with the build I linked above?

Hershbja commented 2 years ago

Does it work with the build I linked above?

As for the result i would like (the grave stays valid so the player can retrieve their inventory), no it doesn't work. I'll get some screenshots and share them

Hershbja commented 2 years ago

Without the head, you cannot "break" the grave to get it back. Placing the head back onto does not work either.

2021-12-16_14 26 10 2021-12-16_14 26 12 2021-12-16_14 26 39 2021-12-16_14 26 56

Just to make sure with installing updates. You replace the plugins.jar and restart the server correct?

Hershbja commented 2 years ago

I just discovered that heads (place on the ground) when hit with flowing water, will pop off. So possibly have another option the user can break to get their items?

Hershbja commented 2 years ago

Player tested the latest build you made. Retrieving items do not delete the old grave's armor stands so i am forced to kill all armorstands.

BenCodez commented 2 years ago

What about now? https://bencodez.com/job/GraveStonesPlus/

I tested it myself, seems to work, but constantly fights water, might have to change that

Hershbja commented 2 years ago

What about now? https://bencodez.com/job/GraveStonesPlus/

I tested it myself, seems to work, but constantly fights water, might have to change that

It works now. I see what you mean by it fighting water. You could probably have it place a block from where the water is coming from. or potentially move the death stand higher in the stream where the "stagnant" flowing water is so that it doesn't pop the head off.

BenCodez commented 2 years ago

I have no way of detected where the water comes from, I do like the idea of moving the grave up, just can't place a grave in the air without other issues

Hershbja commented 2 years ago

I have no way of detected where the water comes from, I do like the idea of moving the grave up, just can't place a grave in the air without other issues

is it possible to detect if the head breaks from water to just replace the head back onto the grave? Because once the water passes it's "stagnant" and won't cause problems.

BenCodez commented 2 years ago

That's exactly what I'm doing right, just causes the water to update, not sure an easy way around that currently

BenCodez commented 2 years ago

https://bencodez.com/job/GraveStonesPlus/ I think I fixed issues with the water now.

Hershbja commented 2 years ago

Perfect it works!