search

BenCodez / GraveStonesPlus

5 stars 2 forks source link

basic fix for dupe bug #35

Closed Carter4242 closed 3 months ago

Carter4242 commented 3 months ago

https://github.com/BenCodez/GraveStonesPlus/issues/33

BenCodez commented 3 months ago

grave.claim already calls removegrave. Shouldn't make any difference calling it twice. Have you tested if it makes a difference?

Carter4242 commented 3 months ago

sorry writing actual fix now - how do I build this? Via Maven?

Carter4242 commented 3 months ago

btw can confirm the issue is real, my server members also found it independently.

BenCodez commented 3 months ago

use maven

Carter4242 commented 3 months ago

this also doesn't work. Maybe come back in an hour and see if I fixed it my bad.

BenCodez commented 3 months ago

Try what I said on the original issue?

On Fri., May 24, 2024, 5:40 p.m. Carter P, @.***> wrote:

this also doesn't work. Maybe come back in an hour and see if I fixed it my bad.

— Reply to this email directly, view it on GitHub https://github.com/BenCodez/GraveStonesPlus/pull/35#issuecomment-2130404111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIQN74AHYPN5HLQM3F4L3ZD6XTFAVCNFSM6AAAAABIIHZT2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQGQYDIMJRGE . You are receiving this because you commented.Message ID: @.***>

Carter4242 commented 3 months ago

I am on the latest version from your link, I am using display entities as well. This only occurs if players can get player heads from another source.

BenCodez commented 3 months ago

I am on the latest version from your link, I am using display entities as well. This only occurs if players can get player heads from another source.

What happens if you don't use display entities? What other source are you getting heads from?

Carter4242 commented 3 months ago

Players can get heads from another plugin on the server. The same error occurs when not using display entities.

Carter4242 commented 3 months ago

@BenCodez I'm sorry I was having difficulty building because of the updates you pushed like 4 days ago (that broke the local building for some reason). I can confirm that the change I pushed does work. I moved it out of the check owner if statement to its own. Obviously, it's not ideal to do things this way, but if you have a method of obtaining PLAYER_HEADs this would be required to prevent duping.

BenCodez commented 3 months ago

https://github.com/BenCodez/GraveStonesPlus/commit/33e0a6794d20d1b25210aa3c433fd3be2b2ffd1a

https://bencodez.com/job/GraveStonesPlus/

Should be good now