BenCodez / VotingPlugin

Plugin on SpigotMC
Other
83 stars 68 forks source link

Sometimes players dont get rewards #818

Closed HiMyNameIsBoxxy closed 4 years ago

HiMyNameIsBoxxy commented 4 years ago

Dont know 2 months ago Plugin version and spigot version.

Describe the bug When players vote, they sometimes get the reward and sometimes dont. It is confirmed that the votes went through just no reward. Is my file corrupted?

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots/Configs If applicable, add screenshots to help explain your problem and/or configs relating to the issue.

Additional context Add any other context about the problem here.

HiMyNameIsBoxxy commented 4 years ago

https://pastebin.com/EEsuDmZ9

https://pastebin.com/Qn4qea2z

BenCodez commented 4 years ago

Reward files? Does the server get the vote?

HiMyNameIsBoxxy commented 4 years ago

They are not getting the vote points. I am using NuVotifier The author doesnt seem responsive and wonder if you have any clue what triggered this.

BenCodez commented 4 years ago

Regardless of vote setup there will be a console message and a broadcast when the server gets a vote. Do you get that?

HiMyNameIsBoxxy commented 4 years ago

This is what I got: 27.05 07:00:24 [Server] INFO Received a vote from service site 'MCSL' by player 'McCovfefeClub'! 27.05 07:00:24 [Server] INFO Thanks McCovfefeClub for voting on MCSL

27.05 07:05:33 [Server] INFO Received a vote from service site 'PlanetMinecraft.com' by player 'Maxonym'! 27.05 07:05:33 [Server] INFO Thanks Maxonym for voting on Planet Minecraft 27.05 07:05:33 [Server] INFO Maxonym just received [Member] rewards!

Some players get it as you can see

On Wed, 27 May 2020 at 06:53, Ben notifications@github.com wrote:

Regardless of vote setup there will be a console message and a broadcast when the server gets a vote. Do you get that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ben12345rocks/VotingPlugin/issues/818#issuecomment-634322330, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXI7T22DS6L5I6VOFYBJ5TRTRB7DANCNFSM4NKNKF4A .

HiMyNameIsBoxxy commented 4 years ago

This is happening randomly btw. McCovfefeClub sometimes get the rewards.

BenCodez commented 4 years ago

Send the rewards you have?

HiMyNameIsBoxxy commented 4 years ago

https://pastebin.com/9yFEfbHM These are separated files just in the same paste bin

HiMyNameIsBoxxy commented 4 years ago

I am starting to believe that some user's data got corrupt during some crashes which prevented them from receiving votes. Or ir could be DiscordSRV.

BenCodez commented 4 years ago

Maybe try using permissions as the requirement rather than vaultgroup? You can also set debug level to Extra to see what is happening

On Thu, May 28, 2020, 3:51 AM HiMyNameIsBoxxy notifications@github.com wrote:

I am starting to believe that some user's data got corrupt during some crashes which prevented them from receiving votes. Or ir could be DiscordSRV.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ben12345rocks/VotingPlugin/issues/818#issuecomment-635177500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIQN3AKFIH2AAXHKG7N7TRTYJZJANCNFSM4NKNKF4A .

HiMyNameIsBoxxy commented 4 years ago

How can I do that

HiMyNameIsBoxxy commented 4 years ago

Can not giving reward caused by one person having multiple groups?

HiMyNameIsBoxxy commented 4 years ago

How can I give reward with permission anyway. I have been using the cofig to give

BenCodez commented 4 years ago

Have RequirePermission: true and Permission: 'perm' in the reward

On Thu, May 28, 2020, 10:08 AM HiMyNameIsBoxxy notifications@github.com wrote:

How can I give reward with permission anyway. I have been using the cofig to give

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ben12345rocks/VotingPlugin/issues/818#issuecomment-635372618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECIQN6H7HZLTCOXYHUHQNDRTZV4RANCNFSM4NKNKF4A .

HiMyNameIsBoxxy commented 4 years ago

Does that mean if they have the perm node when they vote they get the rewards?

HiMyNameIsBoxxy commented 4 years ago

Ignore everything above https://pastebin.com/yvUeHmFY Im getting the random rewards and the diamond sometimes but when i get diamond the game doesnt say I got a lucky bonus or some sort.

HiMyNameIsBoxxy commented 4 years ago

Need help urgent

BenCodez commented 4 years ago

You need to provide more info.

HiMyNameIsBoxxy commented 4 years ago

It is okay I solved the issue! Now this question, is this correct?

Require permission to give this reward file

Permission is AdvancedCore.Reward.(REWARDNAME) by default

E.g: AdvancedCore.Reward.Adept RequirePermission: true

BenCodez commented 4 years ago
RequirePermission: true
Permission: 'perm here'

Something like that.

HiMyNameIsBoxxy commented 4 years ago

Is this correct? https://pastebin.com/bEpQTHTG Something is wrong I am sure

BenCodez commented 4 years ago

Pastebin?

BenCodez commented 4 years ago

You could just have all the rewards there. the last broadcast line 63 missing a '

Also no fallback message set.

Copy and paste it here: https://yaml-online-parser.appspot.com/

Should not give an error on that.

HiMyNameIsBoxxy commented 4 years ago

Also For first vote How can I make it so that I give 1 diamond?

BenCodez commented 4 years ago

Just add an item under FirstVote reward in the config.

HiMyNameIsBoxxy commented 4 years ago

Understood and how would you add all the items in there? I could not do it. Got example?

BenCodez commented 4 years ago
AdvancedPriority:
  Gold:
    Chance: 30
    Items:
      Gold:
        Material: GOLD_INGOT
        Amount: 1
    Messages:
      Broadcast: '&6%player% also received a &7[Gold] &6bonus!'
HiMyNameIsBoxxy commented 4 years ago

Oh ok thank you. Do you have any idea of how to give heads or spawners? I am using minablespawners.

BenCodez commented 4 years ago

Command I guess? You can add Skull: 'PLAYERNAME' under the item for skulls

HiMyNameIsBoxxy commented 4 years ago

https://pastebin.com/WSQ2BN5G Here is my firstvote. Is this correct

HiMyNameIsBoxxy commented 4 years ago

Also, how does top voter get detect? After a month or a week they automatically receive the reward after logging in? Just need to edit the topmonthly file?

BenCodez commented 4 years ago

You can't use the reward file for that unless you listed the reward file in the config.yml.

Just copy what you have in the config in that case.

Top voters will be given on login (unless you do something to prevent that)

HiMyNameIsBoxxy commented 4 years ago

So what do I put here?

FirstVote: [] (All in one line)

Rewards will be given if there is a reward to give

The entire reward or just the reward file? If so how.

BenCodez commented 4 years ago

Well either.

FirstVote:
  Items:
    1:
      Material: 'LEATHER_HELMET'
      Amount: 1
      Durability: 30
      Name: '&bCovfefe's Gift'
      Lore: 
      - 'The start of something great....'
    2:
      Material: 'LEATHER_CHESTPLATE'
      Amount: 1
      Durability: 20
      Name: '&bCovfefe's Gift'
      Lore: 
      - 'The start of something grand....'
    3:
      Material: 'LEATHER_LEGGINGS'
      Amount: 1
      Durability: 20
      Name: '&bCovfefe's Gift'
      Lore: 
      - 'The start of something beautiful....'
    4:
      Material: 'LEATHER_BOOTS'
      Amount: 1
      Durability: 30
      Name: '&bCovfefe's Gift'
      Lore: 
      - 'The start of something long lasting....'
    5:
      Material: 'APPLE'
      Amount: 16
      Name: '&aCovfefe's Gift'
      Lore: 
      - 'Maybe don't eat me'
    6:
      Material: 'LANTERN'
      Amount: 8
      Name: '&aCovfefe's Gift'
      Lore: 
      - 'Let there be light!'

    6:
      Material: 'OAK_BOAT'
      Amount: 1
      Name: '&aCovfefe's Gift'
      Lore: 
      - 'Away from spawn....'

    6:
      Material: 'RED_BED'
      Amount: 1
      Name: '&aCovfefe's Gift'
      Lore: 
      - 'Speeds up the lonely night.'
  Potions:
    SPEED:
      Duration: 1200
      Amplifier: 2
  Messages:
    Player: '&6You voted for your first time. Thank you! Here is to aid your humble start....'
HiMyNameIsBoxxy commented 4 years ago

Thank you. Is it possible to have multiple vote parties? For example: 1000 votes a month 2000 votes a month 100 votes a week 200 votes a week

BenCodez commented 4 years ago

No, just one for vote party.

HiMyNameIsBoxxy commented 4 years ago

Need some help for this https://pastebin.com/pDFAPyMK Not sure what went wrong!

BenCodez commented 4 years ago

'&bCovfefe's Gift'

Use " on the ends.

https://yaml-online-parser.appspot.com/

Will tell you if there is any more.

HiMyNameIsBoxxy commented 4 years ago

Just in case you didnt see i added something at the bottom not sure if it is correct

URL:
  # Standard item format, lore is automaticly applied 
  Item:
    Material: 'BOW'
    Data: 0
    Amount: 1
    Name: '&4URL'
    # You can set skulls of the player using the following
    # Remove the # to enable
    #Skull: '%Player%'
Next:
  Item:
    Material: 'COMPASS'
    Data: 0
    Amount: 1
    Name: '&4Next'
Last:
  Item:
    Material: 'CLOCK'
    Data: 0
    Amount: 1
    Name: '&4Last'
Total:
  Item:
    Material: 'CHEST'
    Data: 0
    Amount: 1
    Name: '&4Total'
Top:
  Item:
    Material: 'SIGN'
    Data: 0
    Amount: 1
    Name: '&4Top'
Today:
  Item:
    Material: 'BOOK'
    Data: 0
    Amount: 1
    Name: '&4Today'
Shop:
  Item:
    Material: 'DIAMOND'
    Data: 0
    Amount: 1
    Name: '&4Vote Shop'
    Lore:
    - '&aYou currently have %points% points'
Top Monthly Voter Reward:
  Item:
    Skull: '%Player%'
    Data: 0
    Amount: 1
    Name: '&4Top Monthly Voter Reward'
    Lore:
    - '&61st Place: &c[Pet Llama] &72nd Place: &c[Pet Chicken]'
BenCodez commented 4 years ago

That won't work, not sure why you did that.

HiMyNameIsBoxxy commented 4 years ago

I wanted to add one more category. Is there a way? Also do I need to install AdvancedCore for permission to work?

BenCodez commented 4 years ago

Oh, that you were using that as a reward, that will work then.

No need to install AdvancedCore, it's not a plugin.

HiMyNameIsBoxxy commented 4 years ago

Actually, I just want to have that info displayed somewhere easy to find. And the config seems to still be wrong.

BenCodez commented 4 years ago

You must have a yml error somewhere.

HiMyNameIsBoxxy commented 4 years ago

WARN [VotingPlugin] RequirementInject Validator: Donor, Directly Defined: false Path: Chance : Chance is 100, if intended then remove the chance option, as it's unneeded 28.05 20:28:58 [Server] WARN [VotingPlugin] RewardInject Validator: Donor, Directly Defined: false Path: RandomCommand : No rewards listed for random reward 28.05 20:28:58 [Server] WARN [VotingPlugin] RequirementInject Validator: High, Directly Defined: false Path: Chance : Chance is 100, if intended then remove the chance option, as it's unneeded 28.05 20:28:58 [Server] WARN [VotingPlugin] RewardInject Validator: High, Directly Defined: false Path: RandomCommand : No rewards listed for random reward 28.05 20:28:58 [Server] WARN [VotingPlugin] RequirementInject Validator: Low, Directly Defined: false Path: Chance : Chance is 100, if intended then remove the chance option, as it's unneeded 28.05 20:28:58 [Server] WARN [VotingPlugin] RewardInject Validator: Low, Directly Defined: false Path: RandomCommand : No rewards listed for random reward 28.05 20:28:58 [Server] WARN [VotingPlugin] RequirementInject Validator: Mid, Directly Defined: false Path: Chance : Chance is 100, if intended then remove the chance option, as it's unneeded 28.05 20:28:58 [Server] WARN [VotingPlugin] RewardInject Validator: Mid, Directly Defined: false Path: RandomCommand : No rewards listed for random reward 28.05 20:28:58 [Server] WARN [VotingPlugin] RequirementInject Validator: Staff, Directly Defined: false Path: Chance : Chance is 100, if intended then remove the chance option, as it's unneeded 28.05 20:28:58 [Server] WARN [VotingPlugin] RewardInject Validator: Staff, Directly Defined: false Path: RandomCommand : No rewards listed for random reward 28.05 20:28:58 [Server] ERROR [VotingPlugin] Failed to load Config.yml

BenCodez commented 4 years ago

28.05 20:28:58 [Server] ERROR [VotingPlugin] Failed to load Config.yml

Can't help without you sending the config.

HiMyNameIsBoxxy commented 4 years ago

https://pastebin.com/Ch32miEL

BenCodez commented 4 years ago

Just paste it in here: https://yaml-online-parser.appspot.com/

I shouldn't need to walk you through configs, I think that's a skill every server owner should know.

https://pastebin.com/UrfrF6FD

Should work I think.

HiMyNameIsBoxxy commented 4 years ago

Thank you so much for the help! I am new and still learning. Do you have any chance know why planetmc isnt working for voting? When people vote nothing happens and I have verified the info twice. Is this a common issue?

BenCodez commented 4 years ago

Does the server get the vote? Check console on a vote.