BenDB3199 / Attitude_from_quaternions

The code takes in quaternions and a timestamp along with TLE data from the OPS-SAT and outputs satellite attitude information like roll, pitch, yaw and angle to nadir.
0 stars 0 forks source link

Second version without ground visualization #18

Closed BenDB3199 closed 3 years ago

BenDB3199 commented 3 years ago

@TanguySoto After your update, there is also the ground visualization code. I just wanted to ask if there is a reason to keep this in the version that goes on the satellite? Because if there isn't, we should create a second version for the satellite that does not include the ground_visualization folder. This would also remove the ground_visualization package dependencies and make the application more lightweight for onboard purposes.

georgeslabreche commented 3 years ago

@BenDB3199 you may have missed this TODO comment: https://github.com/BenDB3199/Attitude_from_quaternions/blob/347975725a9ee156d1e93339b3eecc93678e79e0/attitude_app/app.py#L10

TanguySoto commented 3 years ago

I think it is fine to keep everything in the same repository.

I was planning on making app.py dynamic but it could be simpler indeed to create another app_ground.py within the same repository to make the entry point clear.

I don't know how you plan to package it for space but you will just need to take app.py, it's configuration file and the correct sub-package (attitude_processor) along with its dependencies. The ground side doesn't interfere.

BenDB3199 commented 3 years ago

@georgeslabreche Thanks for the notice. Just to make sure: arg parser, basically means the command line interface, right?

TanguySoto commented 3 years ago

@BenDB3199 Yes! But see my comment above:

Edit: I have done this separation in this branch that I'll soon merge, don't work on it. Along with more changes to the visualizer.