BenFradet / RiotSharp

C# wrapper for the Riot Games API
http://benfradet.github.io/RiotSharp/
MIT License
301 stars 145 forks source link

List all possible issues from the Riot API v3 #343

Closed BenFradet closed 7 years ago

BenFradet commented 7 years ago

https://discussion.developer.riotgames.com/articles/652/riot-games-api-v3.html

MingweiSamuel commented 7 years ago

They are removing batched calls? That could really decrease throughput

BenFradet commented 7 years ago

It seems so yeah :'(

MingweiSamuel commented 7 years ago

They have added per-endpoint rate limit functionality. Currently the limit is 2000req/sec for all endpoints, so it does not affect anything. In the future if the per-endpoint limit goes down or key rate limits go up (or if product key that has higher non-standard rate limits was used) it could be an issue. For now, not worth worrying about, but worth noting

(https://developer.riotgames.com/rate-limiting.html)

BenFradet commented 7 years ago

closing, since the change is happening today, problems will surface on their own